patjak / facetimehd

Reverse engineered Linux driver for the FacetimeHD (Broadcom 1570) PCIe webcam
GNU General Public License v2.0
1.35k stars 160 forks source link

v4l2: accommodate to struct filed rename of vb2_buffer::min_buffers_needed #292

Closed vicamo closed 5 months ago

vicamo commented 6 months ago

Failed to build against v6.8-rc4 due to upstream kernel commit 80c2b40a5139 ("media: videobuf2: core: Rename min_buffers_needed field in vb2_queue"):

/var/lib/dkms/facetimehd/0.5.18/build/fthd_v4l2.c: In function ‘fthd_v4l2_register’:
/var/lib/dkms/facetimehd/0.5.18/build/fthd_v4l2.c:687:10: error: ‘struct vb2_queue’ has no member named ‘min_buffers_needed’
  687 |         q->min_buffers_needed = 1;
      |          ^~
make[2]: *** [scripts/Makefile.build:243: /var/lib/dkms/facetimehd/0.5.18/build/fthd_v4l2.o] Error 1
paralin commented 5 months ago

@patjak this fixes kernel 6.8.x 👍🏽

patjak commented 5 months ago

Thanks for the fix!

mulderje commented 5 months ago

Thank you for the fix! Is it possible to cut a dot release with this included?

patjak commented 5 months ago

Sure, here's the new release https://github.com/patjak/facetimehd/releases/tag/0.6.8.1

mulderje commented 5 months ago

Many thanks! Attempting to package up for fedora here: https://github.com/mulderje/facetimehd-kmod-rpm.

Please let me know if you have any interest in me pushing the spec files upstream once they are working.