patka / cassandra-migration

Schema migration library for Cassandra
MIT License
152 stars 47 forks source link

Support new java-driver-core 4.0 #41

Closed joachse closed 5 years ago

joachse commented 5 years ago

Hi,

Are there any plans on supporting the new Cassandra library java-driver-core?

patka commented 5 years ago

Hi,

Yes there is. I am currently just thinking how to make the transition smooth for library users as the drivers API is unfortunately not backward compatible.

Cheers Patrick

albertpastrana commented 5 years ago

Hi @patka, what's the status of this issue? Do you need any help? We'd like to upgrade the driver and are blocked by the library, so will be more than happy to give you a hand! If it's of any help, as a library user I'd be fine if you just generate a new major version for your library?

patka commented 5 years ago

Hi Albert,

hm, actually I replied to you yesterday but obviously the mail did not make it to Github. Anyway, on my commute home yesterday I was able to integrate the new version into the library. What is left are the integration tests and some testing. The integration tests are a little bit more tricky as cassandra-unit does also not yet support the driver in version 4 but Maven of course resolves to the latest version of the library. So, I have to find a way to test this. Worst case scenario is that for the time being the tests only work when there is a Cassandra node running on localhost or something like this. I never wanted this scenario and I hope that there will be a better solution, either now or soon.

As for the timeline. My plan is to get this done on the weekend. I will most likely then create a branch v2_4 from which I can create a release v2.2.1_v4. Like this there is the possibility to create a new release of the library with version 3 of the driver, in case of a bug, until Datastax finally deprecates the version 3.

So, unless there is something unforeseen you should get something by next week what you can use to test the migration.

Cheers Patrick

patka commented 5 years ago

Hi,

there is a new branch master_v4 that contains an updated version with the changes to use the driver v4. As the documentation is not yet updated here are some things to consider:

It would be great if you could give it a try and let me know if you have some issues. Otherwise I would create a release soon.

Cheers Patrick

albertpastrana commented 5 years ago

Hi @patka, I've been playing a bit with it and it looks like this branch working for me, thanks a lot!

patka commented 5 years ago

Great! So I will see that I get a release out in the next couple of days.

patka commented 5 years ago

I just pushed the changes required for the Spring Boot Starter. If my kids don't cross my plans I will release version 2.2.1_v4 this evening.

albertpastrana commented 5 years ago

That's excellent news, thanks a lot @patka!

patka commented 5 years ago

I just released the library. Normally it takes a couple of hours until it is available in the Maven repos. Let me know if there are any issues. Glad I could help :)

legart commented 4 years ago

Any plans on a _v4 version of 2.3?

patka commented 4 years ago

Hi,

yes, as a matter of fact I have :)

But as most other people I am currently working from home with two kids to take care of. I have it on my agenda and want to do it but I can currently not provide any estimate.

patka commented 4 years ago

I released v2.3.0_v4. Give it some time to propagate through the maven repos.