patleeman / quill-markdown-shortcuts

Quill.js module that converts markdown to rich text formatting while typing.
https://patleeman.github.io/quill-markdown-shortcuts/
140 stars 49 forks source link

It should stop matching when typing in a code block #11

Closed PeachScript closed 6 years ago

PeachScript commented 6 years ago

Versions

The vue editor version from doc: https://github.com/aral/quill-markdown-shortcuts-for-vue-quill-editor

What is expected?

This plugin stop matching when I typing in a code block.

What is actually happened?

This plugin still work and replace some code like /* comment message */.

How to reproduce it?

Open the live example of doc, and create a code block through ```,then try to type /* */.

Almost forgot, thanks for your great plugin!

aral commented 6 years ago

Can confirm that this is also an issue with the main repo (https://patleeman.github.io/quill-markdown-shortcuts/)

PeachScript commented 6 years ago

Hello @patleeman , I have been create a PR to fix this problem, could you check it?

patleeman commented 6 years ago

@PeachScript Thanks for putting this together!

I forgot to add this instruction to the readme, but can you do a npm install and npm run build to compile the built assets as well? That will generate a new dist/markdownShortcuts.js with your changes.

Great work and thanks for pulling this PR together.

patleeman commented 6 years ago

Oh and @aral is the one who is managing the vue component repository.

PeachScript commented 6 years ago

@patleeman that's OK, I've updated, and @aral could you sync changes to your repository from upstream?

patleeman commented 6 years ago

Merged, thanks @PeachScript

PeachScript commented 6 years ago

My pleasure @patleeman