search

patleeman / quill-markdown-shortcuts

Quill.js module that converts markdown to rich text formatting while typing.
https://patleeman.github.io/quill-markdown-shortcuts/
140 stars 49 forks source link

Remove support for list item with * #28

Closed p-salmon closed 5 years ago

p-salmon commented 5 years ago

With the latest version of Quill, the support for list starting with * has been added by default: https://github.com/quilljs/quill/pull/1819

The following line were conflicting with this behaviour, creating weird behaviour where two lines were being cleaned.

We've removed the support for * but let the support for +. We haven't renamed the match and let the asterisk-list intentionally, happy to change it if needed.

Thanks again for the awesome project, it's been really useful for us!

patleeman commented 5 years ago

Thanks for updating this.

I'm thinking we should update the minor version to reflect this fairly large change. What do you think?

Also, do you think we should pin the dependency in the package.json to the latest version?

p-salmon commented 5 years ago

@patleeman Thanks for your review, I've added a comment and updated the version. I can squash the commit for another PR if needed.

Also, do you think we should pin the dependency in the package.json to the latest version?

I don't think it's necessary but maybe I am missing something.

p-salmon commented 5 years ago

Hey @patleeman ! Any news on this? Thanks again for the project :)

patleeman commented 5 years ago

Thanks for the work on this @p-salmon

p-salmon commented 3 years ago

Hey @patleeman ! It's been a while but would be nice to have a new version with this fix ^^ Thanks!