patleeman / quill-markdown-shortcuts

Quill.js module that converts markdown to rich text formatting while typing.
https://patleeman.github.io/quill-markdown-shortcuts/
140 stars 49 forks source link

Formats such as block-quotes, code-blocks, code are unescapable. #39

Open wooolfgang opened 4 years ago

wooolfgang commented 4 years ago

Currently, there is no way to escape from formats such as blockquotes and code-blocks. The favorable behavior UX-wise is to remove the format when the current line is empty.

Here's a demo of the issue: https://www.loom.com/share/392c057b0a0147e0bbf0bed13adbb67e

If anyone's interested, I've forked this current branch and made some fixes that solve this issue here forked branch.

Here's the demo of the updated UX behavior: https://www.loom.com/share/55f49afcdd9c473da9bb09653fb38abf

tsi commented 4 years ago

Yes, that's annoying, we need this too. any chance it's merged into main repo anytime soon?

wooolfgang commented 4 years ago

The author seems inactive in resolving the PR's for this repo. I'd recommend going our route which is forking this instead.

duhaime commented 2 years ago

@wooolfgang your fork looks great. If I wanted to add a change such that the down arrow key moved the cursor out of e.g. the code block in which the user had finished typing (as is the case in Slack), do you know how I could add that behavior?

Was there a reading source that was helpful as you made the changes in your repo? Any advice would be appreciated!

artknight commented 2 years ago

@wooolfgang I tried including the code as a script tag but it throws an error with the import

Screen Shot 2022-09-03 at 8 24 30 AM

It seems that it is complaining about this line const Block = Quill.import('blots/block') that you added.

Any chance you could fix it?