pato-ontology / pato

PATO - the Phenotype And Trait Ontology
https://pato-ontology.github.io/pato/
BSD 3-Clause "New" or "Revised" License
58 stars 18 forks source link

PATO namespace #102

Closed saralafia closed 2 years ago

saralafia commented 8 years ago

The PATO namespace http://purl.obolibrary.org/obo/pato# redirects to https://github.com/pato-phenotype/pato# which is broken. Is it supposed to point to http://www.berkeleybop.org/ontologies/pato/ ? Thanks!

cmungall commented 8 years ago

Where did you come across that URL?

the class PURLs should be

http://purl.obolibrary.org/obo/PATO_nnnnnnnn

The ontology PURLs are

http://purl.obolibrary.org/obo/pato.{obo,owl}

There should be no hash-based PURLs

On 12 Sep 2016, at 16:03, Sara Lafia wrote:

The PATO namespace http://purl.obolibrary.org/obo/pato# redirects to https://github.com/pato-phenotype/pato# which is broken. Is it supposed to point to http://www.berkeleybop.org/ontologies/pato/ ? Thanks!

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pato-ontology/pato/issues/102

saralafia commented 8 years ago

When I imported PATO using Protege, this is the namespace. I've attached my owl file and the import shows on (line 16) - apologies if this goes beyond your scope (if it's an import issue). d1-ECSO.owl.zip

cmungall commented 8 years ago

Thanks for the attachment, I understand the issue now.

It looks like the maintainers of ESCO (is that you?) need to remove line 16. It's actually harmless (namespace declarations in RDF/XML don't have any meaning they are there just for the convenience of shortening URLs). However, it's potentially confusing as (1) it is never actually used as a QNAME in the ESCO file (2) it doesn't correspond to any URL prefix officially used by the PATO ontology (at least not deliberately, it's possible we are somehow indirectly at fault here)

cmungall commented 8 years ago

Unrelated to namespaces, but dataone users may have an opinion on this ticket: #101

saralafia commented 8 years ago

Thanks! I removed the line but the issue isn't resolved so I think the problem is on my end with the PATO import. I really appreciate the quick help.

cmungall commented 8 years ago

Ah yes, it's from PATO_import.owl in sem-prov-ontologies/observation

however, I see the actual issue is on the PATO end, or rather on the OBO/OWL translation end.

The official PURLs for PATO subsets are of the form http://purl.obolibrary.org/obo/pato#value_slim

These don't resolve to anything about the subset itself. I have fixed the PURLs so at least http://purl.obolibrary.org/obo/pato resolves to the home page on github. I may be able to put in # anchors for some of the subsets.

But ultimately hash PURLs are bad, but for various reasons it would be too hard to fix these now.

dataone may want to consider stripping some annotations, I doubt the subsets are useful to you

shawntanzk commented 2 years ago

Hopefully this is resolved now? since it's from 2016 I'm going to close this, but please do reopen and place it in https://github.com/orgs/obophenotype/projects/5 if this is still a problem that needs to be fixed. Thanks