search

patou / gitmoji-intellij-plugin

Intellij plugin for add a button on the commit dialog to add gitmoji
https://plugins.jetbrains.com/plugin/12383-gitmoji/
Apache License 2.0
65 stars 16 forks source link

:alien: Add isModified for ComboBox #25

Closed HwanChang closed 2 years ago

HwanChang commented 2 years ago

This is a problem from the 2021.3 and later versions.

The Configurable interface no longer supports the equal check method for ComboBox from version 2021.3

So I added a method to GitMojiConfig.kt.

image image

patou commented 2 years ago

Thanks for the pull request. I will review and publish a new version

patou commented 2 years ago

Thanks @HwanChang for the PR

HwanChang commented 2 years ago

@patou Thanks for merging the PR.

patou commented 2 years ago

@patou Thanks for merging the PR.

The new version is live... Thanks for your contribution.

HwanChang commented 2 years ago

@patou Thanks for merging the PR.

The new version is live... Thanks for your contribution.

It works when using MacOS, but it doesn't work in Windows OS. Intellij in Windows OS cannot download the new version plugin. There seems to be an error in the pluginName of gradle.properties. Because Windows OS doesn't support : in the file name.

patou commented 2 years ago

@patou Thanks for merging the PR.

The new version is live... Thanks for your contribution.

It works when using MacOS, but it doesn't work in Windows OS. Intellij in Windows OS cannot download the new version plugin. There seems to be an error in the pluginName of gradle.properties. Because Windows OS doesn't support : in the file name.

Thanks for the test in Windows . Can you test if it really the : in your Windows ? I have not my PC with me ...

HwanChang commented 2 years ago

Thanks for the test in Windows . Can you test if it really the : in your Windows ? I have not my PC with me ...

@patou Sure..

Test Result

It seems certain that : causes problems. The plugin name is your responsibility, so I think you'd better fix it yourself.

When the plugin name includes :

image

On Windows systems, files and directory names cannot be created with a colon (:). But if a file or directory name is created with a colon on a Linux or Mac operating system, then moved to a Windows system, percent encoding is used to include the colon in the name in the index. File name characters in IBM Documentation

When : is excluded from the plugin name.

image

Test UI in Windows OS.

image image

patou commented 2 years ago

@HwanChang thanks for the test i will correct et soon.

patou commented 2 years ago

Thanks for the test in Windows . Can you test if it really the : in your Windows ? I have not my PC with me ...

@patou Sure..

Test Result

It seems certain that : causes problems. The plugin name is your responsibility, so I think you'd better fix it yourself.

When the plugin name includes :

image

On Windows systems, files and directory names cannot be created with a colon (:). But if a file or directory name is created with a colon on a Linux or Mac operating system, then moved to a Windows system, percent encoding is used to include the colon in the name in the index. File name characters in IBM Documentation

When : is excluded from the plugin name.

image

Test UI in Windows OS.

image image

Thanks the new version is under validation.

I change the build to the last intellij plugin template, and don't understand the pluginName config. It's corrected.

patou commented 2 years ago

Do not hesitate to put a review on the plugin page : https://plugins.jetbrains.com/plugin/12383-gitmoji-plus-commit-button/reviews

Thanks.