search

patractlabs / redspot

Redspot is an Substrate pallet-contracts (ink!) development environment. Compile your contracts and run them on a different networks. Redspot's core forks from Hardhat but changed a lot to suit substrate.
https://redspot.patract.io/
Other
67 stars 22 forks source link

Remove check to not enter in the same directory during build #160

Closed xgreenx closed 2 years ago

xgreenx commented 2 years ago

Removing this check allows developers to specify target_directory during the compilation of contracts like:

CARGO_TARGET_DIR=/cache/target npx redspot compile
VargSupercolony commented 2 years ago

hey @ii-ii-ii , I'd like to request your review on the PR. Although the lint job fails, build succeeds and the local tests succeed too. As the lint failed for previous PRs, I'd be grateful if you checked the PR anyways.

ii-ii-ii commented 2 years ago

hey @ii-ii-ii , I'd like to request your review on the PR. Although the lint job fails, build succeeds and the local tests succeed too. As the lint failed for previous PRs, I'd be grateful if you checked the PR anyways.

There are some problems with this pr, I have previously made some suggestions for changes, but they have not been accepted. I will close this pr and submit another one.