patractlabs / redspot

Redspot is an Substrate pallet-contracts (ink!) development environment. Compile your contracts and run them on a different networks. Redspot's core forks from Hardhat but changed a lot to suit substrate.
https://redspot.patract.io/
Other
67 stars 22 forks source link

resolve target_directory resolve error for cargo-contract v0.8.0+ #66

Closed RoyTimes closed 3 years ago

RoyTimes commented 3 years ago

as mentioned in https://github.com/patractlabs/redspot/issues/65

I made some minor changes to redspot-core/compiler/ink/resolver.ts

The project has no unit test provided. The best I can do is to run a manual test locally on my environment and the issue is resolved at least on my environment.

It's seems quite odd that according to https://github.com/paritytech/cargo-contract/pull/122 workspace metadata generated by cargo metadata --no-deps --format-version 1 should've updated the target_directory field, but it's just not working as expected on my environment and I really do not wanna dig into the cargo-contract code extensively. I am not sure if this is a common problem or it's something with my environment.

ii-ii-ii commented 3 years ago

Thank you, I'll be doing an update to the compiled part of redspot soon to support multiple contracts and multiple languages. pr After the merge, redspot will be released automatically. If you need to upgrade, you can get the new version number and update your project's package.json.

RoyTimes commented 3 years ago

@ii-ii-ii Thanks for the quick response. That sounds great. I'm currently actively developing https://github.com/w3f/Open-Grants-Program/pull/212 and is trying to use more of the Patract stack. I wonder if you guys have any plans to handle storage rent on Substrate chains? If you are open to connect, what's your Riot handle or if you can message me on telegram id: songzhou26

atenjin commented 3 years ago

@ii-ii-ii Thanks for the quick response. That sounds great. I'm currently actively developing w3f/Open-Grants-Program#212 and is trying to use more of the Patract stack. I wonder if you guys have any plans to handle storage rent on Substrate chains? If you are open to connect, what's your Riot handle or if you can message me on telegram id: songzhou26

Hi @RoyTimes, indeed, predicting storage rent and monitor storage rent are in our plan. This some part of work is planning in RedSpot v0.4(which is planning to summit to polkadot treasury plan later), and another part is related to our contract monitor system (have not started now).

For Redspot, the part related to storage rent would be a redspot plugin. This plan is scheduled in March and April.

However, in our view, we think the storage rent may not a good solution, thus in our testnet jupiter (https://github.com/patractlabs/patract) which would re-launch next week, we are planning remove the storage rent part, and then design a new module to charge fee for storage. That's way the storage rent would be designed as a plugin, rather then part of redspot.