Remove PostData, etc. have option of io.Reader/io.Writer

patram / gorest

Automatically exported from code.google.com/p/gorest

0 stars 0 forks source link

 1 Why need to specify the post data, params argument and output type?

    All of post data, params argument and output type can be found from function signature, using order in signature. That will allow to use type defined in other package more easily, like: http://play.golang.org/p/FUj-FXKr71

 2 Why Marshaller takes []byte instead of io.Reader/io.Writer?

    I think use io.Reader/io.Writer will much convenience for streaming io. Direct reading from request.Body or writing to responseWriter will also save a lot of memory if post or response is very large.

Original issue reported on code.google.com by siyabong...@gmail.com on 7 Mar 2013 at 9:24

I've attached a patch for the Marshallers to use an io.Reader. I've internally used this for letting a large file stream down, rather then having to be fully read into memory. Let me know what you think...

patram / gorest

Remove PostData, etc. have option of io.Reader/io.Writer #8