patreek / marketbilling

Automatically exported from code.google.com/p/marketbilling
0 stars 0 forks source link

onStartCommand doesn't return a value in BillingService line 371 #44

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
In BillingService, line 371, the the intent is null then the service stops 
(why?) and returns, but there is no return value.
Code doesn't compile!

Original issue reported on code.google.com by ran.ma...@gmail.com on 27 Aug 2011 at 5:22

GoogleCodeExporter commented 8 years ago
Possibly the same bug:

handleCommand crashes if the intent is null. This can happen in production if 
the billing service was terminated by Android due to low memory, and then 
restarted.

The fix is to check for intent being null before calling intent.getAction().

Original comment by kmans...@gmail.com on 11 Oct 2011 at 12:59

GoogleCodeExporter commented 8 years ago
Kmans, BillingService.java does not compile, beause of line 371, this one:

 public int onStartCommand(Intent intent, int flags, int startId) {
        if (intent == null) {
            stopSelfResult(startId);
>>>>>>>>>>>>            return;
        }

The return value is of type int.

Original comment by reliagil...@gmail.com on 3 Apr 2012 at 12:22