Improve layout of apps list - Githubissues

patri9ck / a2ln-app

A way to display Android phone notifications on Linux (App)

GNU General Public License v3.0

83 stars 7 forks source link

Improve layout of apps list #10

Closed Domi04151309 closed 2 years ago

Domi04151309 commented 2 years ago

Fixes alignment issues of the current list and uses a standard android app bar instead of the custom back button.

patri9ck commented 2 years ago

I think it looks great but the color are a bit wrong in the apps activity (e.g. the background or the top bar). All colors currently used by the app are defined in app/src/main/res/values/colors.xml and app/src/main/res/values-night/colors.xml.

Domi04151309 commented 2 years ago

It should use the correct colors now

patri9ck commented 2 years ago

Looks great! Three more things I notice: Screenshot

The purple color when you are at the top of the list and try to scroll further up
The text color on the top bar
The checkbox color (doesn't look bad but maybe we could use its color at more positions in the app or just give it also a color from colors.xml)

Domi04151309 commented 2 years ago

What exactly do you mean by the text color of the top bar? The other two colors can be done using the theme. I suggest doing them in another PR.

patri9ck commented 2 years ago

Sorry for this taking so long, had a busy week... Screenshot This is what I mean. When compared to other text colors in the app, you can see that it doesn't use @color/text.

Before merging this, I would at least like to change/remove that purple color. Do you know what I have to look for? Unfortunately, I don't know what it's called. The checkbox color is fine for now.

Domi04151309 commented 2 years ago

The greenish color is the colorAccent and the purple one the colorPrimary (see the last commit). To change the app bar's color is more difficult than just changing one value. I highly suggest reading about text colors and the general design components.

patri9ck commented 2 years ago

Thank you very much! It looks great.

I found a way to change the text color in the action bar by setting android:textColorPrimary to @color/text though it only works in light mode. If we cannot find a solution for this, I will merge it.

~~Oh, and by the way, does it have a specific reason that AppsActivity extends AppCompatActivity instead of Activity now?~~ It's needed for the action bar.

patri9ck commented 2 years ago

Merging this as I cannot find a solution and I don't want to hold back these changes because of that small thing.

I will create a new release that includes these changes.