patri9ck / a2ln-app

A way to display Android phone notifications on Linux (App)
GNU General Public License v3.0
83 stars 7 forks source link

F-Droid build failed #24

Closed linsui closed 1 year ago

linsui commented 1 year ago

Mlkit is not FOSS. Could you please take a look? Thanks!

patri9ck commented 1 year ago

Thank you. I will take a look at it.

patri9ck commented 1 year ago

Is there some way to take a look at the build log? For me, there is a 404 on https://monitor.f-droid.org/builds/log/dev.patri9ck.a2ln/7.

linsui commented 1 year ago

It hasn't been built in the buildserver. https://gitlab.com/fdroid/fdroiddata/-/jobs/2812112858

patri9ck commented 1 year ago

I see, thank you. Is there any way to exclude it from the Gradle build script when it is built by F-Droid but otherwise keep it?

linsui commented 1 year ago

You need to add a flavor without it.

jonas-w commented 1 year ago

How about "outsourcing" the qr code scanning?

So for example i could scan it with my camera app and then "opening" the qr code would redirect to the app with the correct parameters.

This would be a workaround for the non FOSS MlKit and also add some convinience.

I don't have much knowledge about Mobile Dev and don't know if this is more work than necessary.

patri9ck commented 1 year ago

I already created a fix which uses the fully open source library ZXing instead of any proprietary Google Play services. I will push my code and create a new release as soon as possible.

I also created this F-Droid forum post where I received very useful help.

jonas-w commented 1 year ago

Oh okay perfect!