patric-r / jvmtop

Java monitoring for the command-line, profiler included

GNU General Public License v2.0

1.22k stars 252 forks source link

Windows stype jvmtop.sh #87

Closed Herschdorfer closed 7 years ago

Herschdorfer commented 7 years ago

hey guys,

just cloned this and build it via mvn on a windows machine. After that the jvmtop.sh had windows style line endings resulting in

-bash: ./jvmtop.sh: /bin/sh^M: bad interpreter: No such file or directory

easy fix, but donno if this is intended like this... ;)

patric-r commented 7 years ago

This seems to be not an issue with jvmtop.sh itself rather than git/your environment. If you clone a git repository using the windows git client, you get windows-style line delimiters (by default) in all text files. They cannot be used with bash. Additionally, git might also get confused when running in a cygwin environment

Please adjust your environment. See also here.

Herschdorfer commented 7 years ago

this is what i just found and pushed a small fix for this. Checked on my fork and was working.

88

patric-r commented 7 years ago

Thank you, that's the way to go.

Herschdorfer commented 7 years ago

thx for merging!