Magnets not detected in iFrames

[GoogleCodeExporter]

What version of Chrome are you using? On what operating system?
Chrome v38.0.2125.111

What client (version?) are you connecting to? Are you using SSL?
Rutorrent v0.9.4
Non-SSL

What steps will reproduce the problem?
1. Create an iFrame containing magnet links (for example, thepiratebay results 
page)
2. Clicking a magnet link within the iframe

What is the expected output? What do you see instead?
Magnet links within iframes are not forwarded to the webUI when clicked.
Right clicking magnet links within iFrames and selecting "Add to Remote WebUI" 
via the context menu works as expected.

Original issue reported on code.google.com by apcl...@gmail.com on 10 Nov 2014 at 3:07

[GoogleCodeExporter]

thepiratebay doesn't seem to use an iframe for their results table, but i see 
what the problem might be. Can you try the attached version using TryNewCode to 
see if that lets you add iframed links?

Original comment by jul...@gmail.com on 10 Nov 2014 at 3:32

• Changed state: Fixed

Attachments:

• remote-torrent-adder.zip

[GoogleCodeExporter]

Wonderful! This did indeed resolve the issue of magnet links within iframes.

For this specific case I was toying around with a proxy which used an iframe 
for remote pages. Prior to this fix, none of the magnet links in the iframe 
would be sent through to the torrent client.

I've kept myself on this custom build for the time being, but will this update 
be rolled into the public version at some point as well?

Thanks again.

Original comment by apcl...@gmail.com on 10 Nov 2014 at 7:03

[GoogleCodeExporter]

yeah, the issue was that by default, chrome extensions will only inject content 
scripts (the scripts that run in the context of the website) into the top level 
frame, however from that context it does not have access to frames or iframes 
beneath that context.

so what was necessary to make this happen can be seen in r6120fdc6cfc7. quite 
simple.

the change will be pushed out soon, i hope. i'm currently waiting on a response 
in issue 117 so the 1.2.3 changelog doesn't look so sparse.

thanks for reporting and testing.

Original comment by jul...@gmail.com on 10 Nov 2014 at 7:09

• Changed state: Verified

[GoogleCodeExporter]

Original comment by jul...@gmail.com on 19 Nov 2014 at 2:11

• Changed state: Deployed