Files being download into "null" directory.

[GoogleCodeExporter]

What version of Chrome are you using? On what operating system?
23.0.1271.101. Max OSX 10.8.2

What client (version?) are you connecting to? Are you using SSL?
ruTorrent. Yes

What steps will reproduce the problem?
1. Options > WebUI > ENABLE Label/Directory interactivity
2. Click a link (e.g. http://example.com/something.torrent)
3. Dialog box appears with the directory drop down contain the options "null" 
and "null".
4. Click "Add Torrent"

What is the expected output? What do you see instead?
Expected output is not to put the download in the root directory. Instead it 
puts it into a directory called "null".

This was working correctly yesterday (2012-12-31) but today (2013-01-01) I got 
this issue.

Original issue reported on code.google.com by dip...@chauhan.net.au on 31 Dec 2012 at 11:21

[GoogleCodeExporter]

thanks for the report.

this happens when you don't enter anything in the fields while adding a 
torrent. it adds the null-values because 
of course, this is undesired behavior.

can you please try out my changes using TryNewChanges and the attached zip file?
just add and configure the extension, enable interactivity, then add a torrent 
without supplying a label/directory combination (i.e. leave the fields empty).
then tell me whether it acts as expected, otherwise i'll have to make some more 
changes.

Original comment by jul...@gmail.com on 1 Jan 2013 at 12:28

• Changed state: Started

Attachments:

• remote-torrent-adder.zip

[GoogleCodeExporter]

sorry, instructions are under TryNewCode.

Original comment by jul...@gmail.com on 1 Jan 2013 at 11:38

[GoogleCodeExporter]

The update fixed the the "null" directory problem.

However it looks like the "Link Catching" is now broken. Whenever I now click a 
*.torrent link, Chrome will download the file instead of bring up the 
"Label/Directory" dialog. To get around this problem and test the new code, I 
used the context menu option instead.

Upon using the context menu option I was able to bring up the "Label/Directory" 
dialog which no-longer shows the "null" option and instead shows an empty 
drop-down box.

Original comment by dip...@chauhan.net.au on 2 Jan 2013 at 12:57

[GoogleCodeExporter]

link catching works fine for me on a clean copy.
can you check the "link catching" tab in the settings; whether the relevant box 
is enabled and whether there are filters in there (that fit the links you're 
trying)?

Original comment by jul...@gmail.com on 2 Jan 2013 at 1:30

[GoogleCodeExporter]

I have tried checking/unchecking the  Options > WebUI tab > "Label/Directory 
interactivity" checkbox. I have tried checking/unchecking the Options > Link 
Catching tab > "Clicks on links" checkbox.

I have left the filters as the default value of:
([\]|\[]|\b)\.torrent\b
torrents\.php\?action=download

I then reverted back to the version found on the Chrome Store and the link 
catcher was working again. Is there something special I need todo when 
installing the new version? I simply followed the TryNewCode instructions.

Original comment by dip...@chauhan.net.au on 2 Jan 2013 at 10:23

[GoogleCodeExporter]

yeah, that regex is wrong...

can you do the following things, please:

1. remove the extension from chrome
2. go to the unpacked extension on your hdd into the folder miscapis/
3. open the file background.js and go to line 92. it should currently look like 
this:
    localStorage["linkmatches"] = "([\\]|\\[]|\\b)\\.torrent\\b[^\-]~torrents\\.php\\?action=download";
4. replace it with this:
    localStorage["linkmatches"] = "([\\]\\[]|\\b)\\.torrent\\b[^\-]~torrents\\.php\\?action=download";
4. re-add the extension as described in TryNewCode

this removes the pipe from the character group might have been improper regex. 
if that was it, it's obviously an unrelated bug that i must have introduced 
sometime between the last stable release and this issue report

Original comment by jul...@gmail.com on 3 Jan 2013 at 12:31

[GoogleCodeExporter]

That update didn't fix it. Chrome still downloads the torrent file instead of 
bringing up the dialog. Anything else I should try?

Original comment by dip...@chauhan.net.au on 3 Jan 2013 at 2:26

[GoogleCodeExporter]

okay, this one should work now (regex was faulty from a few commits back).

Original comment by jul...@gmail.com on 3 Jan 2013 at 12:52

Attachments:

• remote-torrent-adder.zip

[GoogleCodeExporter]

This patch reintroduced the original bug. I am seeing null dictionary issue and 
at the same time the dialog is still not appearing.

If this is working correctly on your machine, what settings are you using? Also 
what version of Chrome.

Original comment by dip...@chauhan.net.au on 3 Jan 2013 at 9:12

[GoogleCodeExporter]

darn, seems like a switched the branch before i made that last zip file. try 
this one, please.

Original comment by jul...@gmail.com on 3 Jan 2013 at 9:26

Attachments:

• remote-torrent-adder.zip

[GoogleCodeExporter]

This fixed both bugs and is working correctly. Thanks.

Original comment by dip...@chauhan.net.au on 3 Jan 2013 at 9:35

[GoogleCodeExporter]

geez, finally. thanks again!

will merge and release via webstore, probably in a few days.

Original comment by jul...@gmail.com on 3 Jan 2013 at 9:40

• Changed state: Verified

[GoogleCodeExporter]

Original comment by jul...@gmail.com on 18 Jan 2013 at 12:00

• Changed state: Deployed