search

patric99 / remote-torrent-adder

Automatically exported from code.google.com/p/remote-torrent-adder
0 stars 1 forks source link

Failure to catch link #79

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
A tracker I use has a download link that is not detected by RTA as a link at 
all.

Right-clicking the 'Download' button doesn't show the "Add to Remote WebUI" 
menu item, and the link-catcher ignores it.

I'm sorry I'm not totally sure what information might be needed to figure out 
the problem, but the html code for the link button is: <input class="btn" 
value="Download" type="button" 
onclick="parent.location='download.php/example.torrent'">

Original issue reported on code.google.com by danielws...@gmail.com on 15 Nov 2013 at 4:16

GoogleCodeExporter commented 9 years ago 
tell them that they're idiots for using inline event attributes like that ;)

i'm not sure if it makes sense to add recognition of crap like this because 
there are a thousand ways that a torrent download may be implemented in a 
similar way, and there's not really a catchall-ability for downloads in 
chrome's api.

so the choice is between supporting the badly designed whim of one tracker and 
keeping the extension clean of these choices of "fixing other people's bad 
code". i'm against that.

Original comment by jul...@gmail.com on 15 Nov 2013 at 4:34

GoogleCodeExporter commented 9 years ago

Original comment by jul...@gmail.com on 11 Jan 2014 at 12:31