patricegautier / unifiZabbix

Zabbix templates to monitor pretty much all Unifi devices
179 stars 35 forks source link

Proposed cosmetic changes #47

Open UntestedEngineer opened 2 years ago

UntestedEngineer commented 2 years ago

See below fork:

https://github.com/UntestedEngineer/unifiZabbix/commit/d45b62ef8ffaaad35899ce151075cdab0b2535e8

patricegautier commented 2 years ago

Hi -

so the rounding is straight forward, but using 'uptime' for the unit means Zabbix won't be able to understand it, and so you will get:

PastedGraphic-1

instead of

PastedGraphic-2
UntestedEngineer commented 2 years ago

This is what I see in my Zabbix deployment when I change the Units to: uptime:

image image
patricegautier commented 2 years ago

and if you go to 'latest data' for the basement AP switch 1?

UntestedEngineer commented 2 years ago

I only changed the Unifi AP and Unifi Switch templates, not the SSH template. All of the devices below are Ubiquiti AP and Switches.

image
patricegautier commented 2 years ago

I’m missing something.. The value doesn’t show ‘Uptime’ in the unit, just days hours minutes seconds..

If I put ’s uptime’ in the unit, I get:

Which is what I would expect..

On Jun 6, 2022, at 11:34 AM, UntestedEngineer @.***> wrote:

https://user-images.githubusercontent.com/106830292/172224214-24332f2f-babf-46b7-a5a1-c6e17caee3bc.png — Reply to this email directly, view it on GitHub https://github.com/patricegautier/unifiZabbix/issues/47#issuecomment-1147759502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFHTJZ76Y2SLDKXPNI4IKTVNZAFFANCNFSM5X5MMYWQ. You are receiving this because you commented.

UntestedEngineer commented 2 years ago

If I revert the units to "S" as per your original template I receive the following:

image

While it is standard Linux/Unix time it is a little harder to read for the average human :). Changing the uptime units from "S" to "uptime" makes it more legible for the average human so we do not have to convert standard Unix/Linux uptime to something that is a bit easier to understand.

patricegautier commented 2 years ago

Ah I think ’S’ vs ’s’ was the problem there.. I’ll just go with ’s’.

On Jun 6, 2022, at 2:10 PM, UntestedEngineer @.***> wrote:

If I revert the units to "S" as per your original template I receive the following:

https://user-images.githubusercontent.com/106830292/172249525-512bba05-c537-4b0e-b986-fffd09eb8b18.png While it is standard Linux/Unix time it is a little harder to read for the average human :). Changing the uptime units from "S" to "uptime" makes it more legible for the average human so we do not have to convert standard Unix/Linux uptime to something that is a bit easier to understand.

— Reply to this email directly, view it on GitHub https://github.com/patricegautier/unifiZabbix/issues/47#issuecomment-1147934078, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFHTJ7GETG62GQ2SP7UZOTVNZSKRANCNFSM5X5MMYWQ. You are receiving this because you commented.

UntestedEngineer commented 2 years ago

When I switched to units "s" one of my switches yielded 1m uptime, however that is incorrect as per the controller it has been up for 30 days.

image

When I switch the units back to "uptime" Zabbix converts and displays the correct uptime:

image
patricegautier commented 2 years ago

Can’t say I understand what’s going on with this one.. Seems a Zabbix bug if anything, since ‘uptime’ is not any sort of known unit, while ’s’ certainly is..

On Jun 6, 2022, at 3:59 PM, UntestedEngineer @.***> wrote:

When I switched to units "s" one of my switches yielded 1m uptime, however that is incorrect as per the controller it has been up for 30 days.

https://user-images.githubusercontent.com/106830292/172262839-f5590e33-00d3-4bd9-8039-36688437fdfa.png When I switch the units back to "uptime" Zabbix converts and displays the correct uptime:

https://user-images.githubusercontent.com/106830292/172262942-4936b884-2171-4498-8b44-d423c1c5a060.png — Reply to this email directly, view it on GitHub https://github.com/patricegautier/unifiZabbix/issues/47#issuecomment-1148013894, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFHTJ5XY3CBCDXM4I5U77DVNZ7G5ANCNFSM5X5MMYWQ. You are receiving this because you commented.