patriciakt
commented
1 year ago Thank you!
On 8. Nov 2023, at 16:02, Eric Coimbra @.***> wrote:
First of all, nice game idea. Kung Fu Panda is one of the most hilarious movies I've ever seen. Jack Black is a gem!
Your script tag links are quite weird. Normally you want to link them to the project itself, not to the github page that holds the file. Something like: "./classes/background.js", "./classes/players.js", "./classes/obstacle.js", "./timer.js", "./canvas.js", "./script.js"
Your folder structure could be a bit better. You should have all your JavaScript files in one folder, normally called js, scripts or src, along with the images and any potential sound files in an assets folder.
I commend you on the jump logic, it's never an easy one to implement. But the amount jumped is not great, perhaps you should make it a bit bigger.
Nice use of classes and DOM manipulation! The classes make your logic and code easier to follow and understand. The use of canvas is also quite nice!
Don't forget to remove unused console.log. It can slow your code down on slower machines!
Overall a nice project, with some clean logic! Well done! If you have any questions, please reach out, we're here to help!
— Reply to this email directly, view it on GitHub https://github.com/patriciakt/the-dragon-warrior/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDHECSXH7AXZSWEVLYTS2FLYDONHJAVCNFSM6AAAAAA7DA6A6SVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DGOBRGAZDMMA. You are receiving this because you are subscribed to this thread.
First of all, nice game idea. Kung Fu Panda is one of the most hilarious movies I've ever seen. Jack Black is a gem!
Your script tag links are quite weird. Normally you want to link them to the project itself, not to the github page that holds the file. Something like:
"./classes/background.js", "./classes/players.js", "./classes/obstacle.js", "./timer.js", "./canvas.js", "./script.js"Your folder structure could be a bit better. You should have all your JavaScript files in one folder, normally called js, scripts or src, along with the images and any potential sound files in an assets folder.
I commend you on the jump logic, it's never an easy one to implement. But the amount jumped is not great, perhaps you should make it a bit bigger.
Nice use of classes and DOM manipulation! The classes make your logic and code easier to follow and understand. The use of canvas is also quite nice!
Don't forget to remove unused console.log. It can slow your code down on slower machines!
Overall a nice project, with some clean logic! Well done! If you have any questions, please reach out, we're here to help!