patriciogonzalezvivo / comfyui_glslnodes

GLSL node for ComfyUI
GNU General Public License v3.0
175 stars 13 forks source link

About the egl api call problem #4

Closed tanglup closed 3 months ago

tanglup commented 3 months ago

My system is Windows. I successfully installed your node. After running it, an error occurred: cannot import name 'egl' from 'glcontext' (D:\Airuanjian\ComfyUIbianxie\ComfyUI_windows_portable\python_embeded\Lib\site-packages\glcontext__init__.py) See if you can solve this problem

patriciogonzalezvivo commented 3 months ago

Hi! Yesterday push a commit where a different backend is assigned depending the OS https://github.com/patriciogonzalezvivo/comfyui_glslnodes/blob/main/node.py#L16-L20

Do you mind checking if it works?

ohnoitsaninja commented 3 months ago

I'm on windows and get

Error occurred when executing glslViewer: Cannot find supported backend: 'wgl'

tanglup commented 3 months ago

嗨!昨天推送了一个提交,根据操作系统分配了不同的后端https://github.com/patriciogonzalezvivo/comfyui_glslnodes/blob/main/node.py#L16-L20

您介意检查一下它是否有效吗?

A new error occurred. Even though the wgl dependency library was installed, it still prompted that the wgl backend could not be found. moderngl and glcontext were also installed. My torch is pytorch version: 2.3.1+cu121 and xformers version: 0.0.27

patriciogonzalezvivo commented 3 months ago

Just push another https://github.com/patriciogonzalezvivo/comfyui_glslnodes/commit/21d63f747d66f5217d60fc7c26a7c00ea66ad562. Do you mind giving it a try?

Sorry for the back and forth.

baram892 commented 3 months ago

I'm on windows and get

Error occurred when executing glslViewer: Cannot find supported backend: 'wgl'

I have the same issue

patriciogonzalezvivo commented 3 months ago

Do you mind updating and trying again?

baram892 commented 3 months ago

I tried again, but I got the same issue. I use comfyUI portable. is this a problem?

baram892 commented 3 months ago

Error occurred when executing glslViewer:

Cannot find supported backend: 'wgl'

File "I:\AI\AI_202406\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "I:\AI\AI_202406\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "I:\AI\AI_202406\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "I:\AI\AI_202406\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_glslnodes\node.py", line 108, in main ctx = moderngl.create_context( ^^^^^^^^^^^^^^^^^^^^^^^^ File "I:\AI\AI_202406\ComfyUI_windows_portable\python_embeded\Lib\site-packages\moderngl__init__.py", line 1936, in create_context ctx.mglo, ctx.version_code = mgl.create_context(glversion=require, mode=mode, settings) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "I:\AI\AI_202406\ComfyUI_windows_portable\python_embeded\Lib\site-packages\glcontext__init__.py", line 51, in get_backend_by_name raise ValueError("Cannot find supported backend: '{}'".format(name))

tanglup commented 3 months ago

只需再按一次21d63f7即可。你介意尝试一下吗?

抱歉,来来回回。

(The error that occurred: AttributeError: module 'moderngl' has no attribute 'get_context' ) --- also My moderngl version is 5.8.0,This version doesn't seem to work, which version do you recommend? 4444

微信图片_20240716182050

ohnoitsaninja commented 3 months ago

Fixed and working for me

patriciogonzalezvivo commented 3 months ago

That's great to hear! @tanglup I'm not sure why is not working. @ohnoitsaninja what version of moderngl is running on your machine? Are you using the portable version of comfyUI?

tanglup commented 3 months ago

That's great to hear! @tanglup I'm not sure why is not working. @ohnoitsaninja what version of moderngl is running on your machine? Are you using the portable version of comfyUI?

Yes, I'm using the official portable version

patriciogonzalezvivo commented 3 months ago

@ohnoitsaninja please upgrade the node and try again. It should be working now

tanglup commented 3 months ago

听到这个消息我很高兴! @tanglup我不确定为什么不工作。@ohnoitsaninja您的机器上运行的是哪个版本moderngl?您使用的是便携版 comfyUI 吗?

After updating to moderngl==5.10.0, I was able to run

baram892 commented 3 months ago

I'm so happy Thank you guys~ it's working~ Thank you~~~~~