patriciogonzalezvivo / glsl-pipeline

Prototype complex pipelines directly from a single shader by branching it into stages
MIT License
80 stars 5 forks source link

πŸŽ‰ 2.0.0 New Feature that can use on React-Three-Fiber, Javascript & even Typescript as well! #3

Closed ammein closed 10 months ago

ammein commented 10 months ago

I made a monorepo package on easy to just publish one npm package but can import different usage types such as React, Javascript and Typescript as well! This can help all react-three-fiber coders use GlslPipeline immediately!!!!

CHANGELOG:


Please refer to /package/CONTRIBUTING.md file to know about this new monorepo style & how is it going to publish. You can reach me anytime to work on this together. 😁

patriciogonzalezvivo commented 10 months ago

Oh wow! Thank you so much @ammein ! this is wonderful. This means once pushed to npm regular JS + threeJs projects will still be supported in the same way? Excuse my ignorance respect to Web development

ammein commented 10 months ago

Absolutely! No breaking changes at all! They can use manually as they used to from V1 release. Only additional method in GlslPipeline class called:

I already created changeset initializer using command changeset init. So you will release the package using changeset/cli commands:

# Build the package first
yarn build

# For contributor, run
yarn changeset

# For maintainers release package
yarn changeset version

# For maintainers, contributors and owners to release package
yarn changeset publish

Side Note: There are some grammars and docs that I need to fix. Later i will push the last code to fix all copywriting and adjust types-helper code.

Aren't you excited?! I myself can't wait to use this on my project! πŸ₯³

You can explore more on my forked repo for this pull request: glsl-pipeline-react

patriciogonzalezvivo commented 10 months ago

Yes I am! This is truly wonderful! Thank you so much. This will allow to use glsl-pipeline in so many project! You really have taken things project to the next level. Incredible work architecting the multiple release and examples too.

patriciogonzalezvivo commented 10 months ago

@ammein I took a look to the code. Fantastic job! I get it now (or at least I think I do, hehehe) this is massive upgrade! I love the fact that you manage to bring support for both TypeScript and React without sacrificing support for vanilla JS for dinosaur like me : ) . Thank you! This will make things better for a lot of people. I added a couple of comments, some propose some minor things. Once that's in I can merge, and then I will follow through your instructions on yarn to publish a new npm version. I might have questions at that point. Again thanks you!

ammein commented 10 months ago

All done! You can merge safely now @patriciogonzalezvivo πŸ₯³

Changelog:

patriciogonzalezvivo commented 10 months ago

Fantastic, let's do it <3 Thank you!

patriciogonzalezvivo commented 10 months ago

@ammein yarn changeset doesn't allow me to do glsl-pipeline, what am I doing wrong? image

ammein commented 10 months ago

Ahh, I already did glsl-pipeline for you firsthand. You can just simply do yarn changeset publish for now. In future, if you want to publish again, you will need to do the yarn changeset first πŸ‘πŸ»πŸ˜ Sorry for helping firsthand that confuses you @patriciogonzalezvivo

patriciogonzalezvivo commented 10 months ago

Awesome! Just publish works like a charm. Thank you so much!