patriciogonzalezvivo / glslEditor

Simple WebGL Fragment Shader Editor
http://editor.thebookofshaders.com
MIT License
2.36k stars 241 forks source link

Export to Openframe not working #49

Open jvolker opened 5 years ago

jvolker commented 5 years ago

When clicking Artwork to [o] button the shader doesn't show up in Openframe.

The console throws these errors:

Modal.js:87 Uncaught TypeError: Cannot read property 'classList' of null
    at ExportModal.onClickOutside (Modal.js:87)
    at HTMLBodyElement.handler (Modal.js:118)
onClickOutside @ Modal.js:87
handler @ Modal.js:118
VM77:1 POST https://thebookofshaders.com:8080/save net::ERR_CERT_AUTHORITY_INVALID

Thanks for any help with fixing this.

jmwohl commented 5 years ago

Seems like maybe just serving the editor via https might fix this?

jmwohl commented 5 years ago

Oh — seems like it is/was, but the SSL cert isn't valid anymore. Updating that should fix it (maybe).

patriciogonzalezvivo commented 5 years ago

That's true. I need a hand for that SSL keys are not my thing

jmwohl commented 5 years ago

Happy to help @patriciogonzalezvivo! Depending on how you're hosting this, it might be as simple as a one-click install from your host — most offer SSL for free now that Let'sEncrypt is around.

patriciogonzalezvivo commented 5 years ago

I'm using a Node.js. Tried doing this https://github.com/patriciogonzalezvivo/shaderLog/blob/master/server.js#L16-L17 https://github.com/patriciogonzalezvivo/shaderLog/blob/master/server.js#L16-L17

But no w luck. or knowladge. We can chat Jonathan and I can give you access to the server if you know how to take it from there

On Aug 18, 2019, at 12:51 PM, Jonathan Wohl notifications@github.com wrote:

Happy to help @patriciogonzalezvivo https://github.com/patriciogonzalezvivo! Depending on how you're hosting this, it might be as simple as a one-click install from your host — most offer SSL for free now that Let'sEncrypt is around.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/patriciogonzalezvivo/glslEditor/issues/49?email_source=notifications&email_token=AACUWIX7SM63UKE6Z4PAKL3QFGR45A5CNFSM4IMSMMGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4RG3XY#issuecomment-522350047, or mute the thread https://github.com/notifications/unsubscribe-auth/AACUWIXIJIFLO6HGNJV3O2LQFGR45ANCNFSM4IMSMMGA.

jmwohl commented 5 years ago

Sure — I've never manually set up a cert like that with node, always used a reverse proxy server in front of node application. But it should work fine as you have it, probably just need to update the cert? @patriciogonzalezvivo if you're still on slack at all, we can connect on the Openframe slack channel, or shoot me an email and I can try to help!