patriciogonzalezvivo / thebookofshaders

Step-by-step guide through the abstract and complex universe of Fragment Shaders.
http://TheBookOfShaders.com
Other
5.96k stars 677 forks source link

Incorrect definition of dot product in glossary #405

Closed oshawa-connection closed 8 months ago

oshawa-connection commented 1 year ago

https://github.com/patriciogonzalezvivo/thebookofshaders/tree/master/glossary/dot#description

The definition of the dot product is not one I'm familiar with. Am I getting confused here? Happy to submit a pr if this is indeed a mistake!

metaleap commented 9 months ago

Maybe it was updated in the meantime, but essentially it describes it as vec1.x*vec2.x + vec1.y*vec2.y which is the same definition as I've seen pretty much everywhere else, too.

(What could at first glance confuse here is naming two vectors x and y ... =)