search

patrick-kidger / equinox

Elegant easy-to-use neural networks + scientific computing in JAX. https://docs.kidger.site/equinox/
Apache License 2.0
2.13k stars 143 forks source link

Add [test] and update CONTRIBUTING #848

Closed dlwh closed 2 months ago

dlwh commented 2 months ago

Makes it easier to set up dev env.

dlwh commented 2 months ago

PTAL

patrick-kidger commented 2 months ago

LGTM! Thanks for the improvement :)

dlwh commented 2 months ago

Of course, I should probably do it in my own projects...

patrick-kidger commented 2 months ago

Unfortunately I had to revert this one. The problem arises with https://github.com/patrick-kidger/equinox/blob/5a40d2ed61871b400674ff3b3c6e8f5ba410d899/.github/workflows/release.yml#L19 that we don't want to install Equinox itself here. That's already being done for us as a source or wheel distribution. And in fact we can't install Equinox using pip install ., as e.g. its pyproject.toml file may not even be present in the wheel. (In practice the first error was Hatch complaining about the lack of LICENSE file.)

Ah well.