search

patrick-kidger / optimistix

Nonlinear optimisation (root-finding, least squares, ...) in JAX+Equinox. https://docs.kidger.site/optimistix/
Apache License 2.0
284 stars 14 forks source link

Clarify task of descent classes #69

Closed johannahaffner closed 1 month ago

johannahaffner commented 1 month ago

Nit: I find "size of the update" to be confusing in this sentence. As I understand it, the descent computes the actual update, using the scalar computed in the search. The latter might be described more accurately as the "size" of the update.

patrick-kidger commented 1 month ago

This LGTM! Thank you for the tidy-up :)

johannahaffner commented 1 month ago

Thanks!