search

patrick-kidger / torchcubicspline

Interpolating natural cubic splines. Includes batching, GPU support, support for missing values, evaluating derivatives of the spline, and backpropagation.
Apache License 2.0
198 stars 18 forks source link

order for derivatives #3

Closed dylgold2000 closed 3 years ago

patrick-kidger commented 3 years ago

Hello there - happy to see you're interested in contributing.

I've got a couple comments but in principle I'm happy to include this.

-The def derivative line has the wrong indentation. -The order argument should have a default value of 1 for backward compatibility. -It would be nice if order > 3 returned zeros.

patrick-kidger commented 3 years ago

Closing as #8 now adds this functionality.