search

patrick-layden / HyperConomy

https://dev.bukkit.org/projects/hyperconomy
GNU General Public License v3.0
35 stars 24 forks source link

Project is still configured for Java 1.6 #148

Open Pingger opened 6 years ago

Pingger commented 6 years ago

The Project is still configured for Java 1.6. Minecraft 1.12 enforces a minimum version of Java 1.8

Pingger commented 6 years ago

Additionally Project does not work with Java 9. only with Java 8 or earlier. Fixed in #149 (the java 8/9 issues, not the build config)

brooklynstarr commented 6 years ago

Made the following change to pom.xml to avoid lamda errors during build:

              source1.8 source
              target1.8 target
Pingger commented 6 years ago

I'm working with that setting on my local fork.

brooklynstarr commented 6 years ago

Awesome and thank you- i'll compile on my end and test. Appreciate you helping keep this plugin updated, it's highly underappreciated, integral to my server, and I refuse to use anything else. Considering I've added tons of custom items to the DB over the years I sure as heck don't want to give it up lol.

Will keep you updated on results from my end- I haven't dipped into 1.13 yet, still working with 1.12 until other plugins start updating.

Thanks again.

roracle commented 6 years ago

@brooklynstarr you say you've added custom items over the years, by any chance are any of them SlimeFun items? I've been wanting to add those but I'm not sure if a good way to set pricing.

If you do or not, how do you determine pricing, and how do you determine items made from other items, as well? (SlimeFun has many many items that require other SlimeFun items to create, so compound materials should affect pricing of final products, but I don't know any way of handling that without just making the base materials themselves the only thing on the market)

brooklynstarr commented 6 years ago

OMG I've been wanting to do that but have wound up using other plugins to do it instead, and with those you just have to specify pricing and nothing else; one of the reasons why I love Hyperconomy is because of this underlying complexity but it's also its Achilles' heel. In the past I've done custom items that are just enchanted versions of regular items, and I set pricing manually.

The only actual slimefun items I've ever added was food, and unfortunately for this it wouldn't retain the custom head textures. I added those by using the additem command while holding it in my hand and giving it a name/median value. This of course will only add the material, and not any of the compound materials- it would be a far stretch to expect hyperconomy to do this by default, it would likely be something that would be done using the java item editor or, like I've done before, exporting the csv file, modifying in Excel then reimporting.