patrick-layden / HyperConomy

https://dev.bukkit.org/projects/hyperconomy
GNU General Public License v3.0
35 stars 24 forks source link

SpiGot 1.13 API update #149

Closed Pingger closed 4 years ago

Pingger commented 6 years ago

Updates several classes to work with the updated API of spigot and CB

Please review the changes made before merging, since some of them WILL break serialization and simple updating.

Fixes #142 Fixes #143 Fixes #148 Fixes #150 Fixes #153

Pingger commented 6 years ago

Known Issues: Enchantments need to be updated in the CSV new Items not yet added (neither Mats, Points, nor Enchantments) (What to do with Cursed enchantments?) https://pastebin.com/qvBPYjsv <- Something is wrong with the NBTTags. The method has been fundamentally changed https://pastebin.com/GqK9xB2P <- Hacky ClassLoader code, that no longer works (works until Java 8, not working with Java 9) Resulting in unusable commands

Pingger commented 6 years ago

@RegalOwl I'm done for now. I don't know what the CMethod in NBTTools should do and therefore can't fix that. Found the method by comparing the mc server source codes And I don't really understand what that ClassLoader Code in the LibraryManager tries to accomplish (Java 9 issue) Fixed by using the intended java way of loading libraries

Pingger commented 6 years ago

Ready to merge

PurpleStormCloud commented 5 years ago

Well this is certainly interesting xD welp I might have done work for nothing now. Well if you can call it that.... Is there at least anything useful we can take from this? What I did there works without issues afaik (I didn't used Maven so I didn't update any refs) have been running it in production for a while without issues https://github.com/RegalOwl/HyperConomy/pull/156

PurpleStormCloud commented 5 years ago

One thing we could do is that we could use Material.values() for the items instead the csv, and for enchanting and stuff, that might be a good idea for the future? I get that its for the price but there should be possibly a better solution to that ....