search

patrick-lenggenhager / HyperCells

HyperCells is a GAP package that allows constructing primitive cells and supercells of hyperbolic lattices based on triangle groups and quotients with normal subgroups.
https://patrick-lenggenhager.github.io/HyperCells/
Other
3 stars 2 forks source link

Edge-tag form returned by TGCellModelGraph does not cover all cases #11

Open patrick-lenggenhager opened 1 month ago

patrick-lenggenhager commented 1 month ago

Relevant part of the documentation Section 4.2, in particular 4.2-1, 4.2-2, 4.2-4, 4.2-5.

Problem Edge-tag form for cell model graphs where no Wyckoff positions are converted to edges, but original edges of the cell graph are used is wrong, it only contains a single Schwarz triangle rather than the usual two.

Suggestion Update in the relevant subsections. Additionally, explicitly specify form (or state how many Schwarz triangles are given) in the model type functions.

patrick-lenggenhager commented 11 hours ago

Note that w is not defined in Section 4.2. This should be added as well.