search

patrickTingen / DataDigger

A dynamic dataviewer for your Progress / OpenEdge databases
https://datadigger.wordpress.com/
MIT License
50 stars 24 forks source link

Move process-architecture check to runtime #103

Open Sil-Boydens opened 10 months ago

Sil-Boydens commented 10 months ago

progress 12 and up don't have a 32 bit compiler (that i'm aware off), but they do have 32 bit clients. this PR moves the process-architecture check from compile time to runtime so a version compiled in 64 bit can be run on 32 bit clients.

tested and validated on version:

patrickTingen commented 10 months ago

Hi Sil,

Big thanks for this pr. I surely will integrate this, but the thing is, I am working on a rather large update where I pull apart lots of code for the index and fields tab. I do this in order to add more tabs and make the code more maintainable. This might take a while since I am quite busy, but be assured that I will use it!

Patrick

Op zo 7 jan. 2024 15:49 schreef Sil-Boydens @.***>:

progress 12 and up don't have a 32 bit compiler (that i'm aware off), but they do have 32 bit clients. this PR moves the process-architecture check from compile time to runtime so a version compiled in 64 bit can be run on 32 bit clients.

tested and validated on version:

  • 10.2B07 32-bit
  • 11.7.14 32-bit
  • 11.7.15 64-bit
  • 12.2.12 32-bit (compiled using 12.2.10 64-bit)
  • 12.2.10 64-bit

You can view, comment on, or merge this pull request online at:

https://github.com/patrickTingen/DataDigger/pull/103 Commit Summary

File Changes

(6 files https://github.com/patrickTingen/DataDigger/pull/103/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/patrickTingen/DataDigger/pull/103, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABN3AHKOY454TMOZ3C3ZYNDYNKYWPAVCNFSM6AAAAABBQL7TL6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DSMJVHEYTGNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Sil-Boydens commented 10 months ago

Hi Patrick,

No worries, i was already aware of the big rewrite for those tabs. You don't have to merge this, just copying the underlying idea is also possible. Just leave the PR open until this functionality is in the main release, so people that need this can find it.

patrickTingen commented 10 months ago

Sounds like a good plan, I will do that. Thanks again for your help!

-- Patrick Tingen

Op zo 7 jan 2024 om 17:09 schreef Sil-Boydens @.***>:

Hi Patrick,

No worries, i was already aware of the big rewrite for those tabs. You don't have to merge this, just copying the underlying idea is also possible. Just leave the PR open until this functionality is in the main release, so people that need this can find it.

— Reply to this email directly, view it on GitHub https://github.com/patrickTingen/DataDigger/pull/103#issuecomment-1880100509, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABN3AHPDHFXZZ47GN2JARELYNLCDNAVCNFSM6AAAAABBQL7TL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGEYDANJQHE . You are receiving this because you commented.Message ID: @.***>