patrickTingen / DataDigger

A dynamic dataviewer for your Progress / OpenEdge databases
https://datadigger.wordpress.com/
MIT License
50 stars 23 forks source link

DataDigger doesn't start when user ini file is missing #32

Closed movedoa closed 6 years ago

movedoa commented 6 years ago

Latest dev version I deleted the DataDigger-username.ini file and now Datadigger doesn't start anymore. Same thing happens when i try to use the Workfolder setting since it is just an empty folder at the first start.

grafik

patrickTingen commented 6 years ago

Hi Alexander,

I tried to reproduce the issue, but could not. Can you give me some more info so I can reproduce it? Every time I deleted the user-ini, it got re-created. Both with the 'WorkFolder' setting in DataDigger.ini and without.

gr

Patrick Tingen

Op di 14 aug. 2018 om 12:09 schreef movedoa notifications@github.com:

[image: grafik] https://user-images.githubusercontent.com/13309951/44085780-ce07a19e-9fba-11e8-86a9-96eb2f366072.png

I deleted the DataDigger-username.ini file and now Datadigger doesn't start anymore

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/patrickTingen/DataDigger/issues/32, or mute the thread https://github.com/notifications/unsubscribe-auth/AFuwHb7IevAWT0WD5x29o9Afn1DaaMd7ks5uQqHngaJpZM4V8JwO .

movedoa commented 6 years ago

Tracked it down, the error happens when the settings cache is set to no

[DataDigger:Cache]
Settings=no
patrickTingen commented 6 years ago

This is a nasty one and probably did not work good in older versions as well. The problem is that the option gives the idea that you can bypass the caching of the setting (hence the name). But in reality this is hardly doable in the current codebase, nor is it needed, I think. Did you encounter this while testing or did you also use it in previous versions?

At the moment I am considering taking it out, unless you can convince me with a good usecase. The reason it was there in the first place was because I was not too confident that the caching mechanism would work, so it was an easy way to turn it off. Mind you: this was DD18 of june 2013. In DD24 you have the option to specify another folder as workfolder, so if you really do not want to / cannot write to the main DD folder, then there are other ways to achieve that.

Removing it would simplify the codebase, which I think is a Good Thing™

gr Patrick Tingen

Op do 16 aug. 2018 om 11:41 schreef movedoa notifications@github.com:

Tracked it down, the error happens when the settings cache is set to no

[DataDigger:Cache] Settings=no

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/patrickTingen/DataDigger/issues/32#issuecomment-413486760, or mute the thread https://github.com/notifications/unsubscribe-auth/AFuwHcjobjHWnHSrBqa2cszuFPQg6a6Qks5uRT4ygaJpZM4V8JwO .

movedoa commented 6 years ago

I am not shure why this was set, maybe there was a reson for it a few years back You can remove it

Btw. for me it would be great to completely disable the user ini files and tell DD to just use the DataDigger.ini but i guess that would be even more work

patrickTingen commented 6 years ago

Merging all settings is something I will keep in mind for a next version. For this version this would be a too big change. I removed the option to suppress settings caching