patrickTingen / DataDigger

A dynamic dataviewer for your Progress / OpenEdge databases
https://datadigger.wordpress.com/
MIT License
50 stars 23 forks source link

quick connect broken #49

Closed SilBoydens closed 5 years ago

SilBoydens commented 5 years ago

in older versions when right clicking in the list of tables before a database was connected, you could select a database relly quickly. in version 24 this trows invallid widget errors image stacktrace: --> selectClickedRow C:/Users/xxx/Desktop/DataDigger-20181003/wDataDigger.w at line 11422 (C:\Users\xxx\Desktop\DataDigger-20181003\wDataDigger.r) menuDropDataBrowse C:/Users/xxx/Desktop/DataDigger-20181003/wDataDigger.w at line 9765 (C:\Users\xxx\Desktop\DataDigger-20181003\wDataDigger.r) C:/Users/xxx/Desktop/DataDigger-20181003/DataDigger2.p at line 197 (C:\Users\xxx\Desktop\DataDigger-20181003\DataDigger2.r) DataDigger.p at line 19 (.\DataDigger.r)

SilBoydens commented 5 years ago

screenshot of the older version where it shows a list of recently connected databases image

patrickTingen commented 5 years ago

Hi Sil,

Thanks for using DataDigger and thanks for reporting this. However, when I test it in my environment, I can see the databases. They have moved one menu level deeper:

[image: image.png]

Although I did notice a bug: newly added database connections do not show up until you restart DataDigger. How is your situation if you restart DataDigger?

Kind regards Patrick Tingen

Op wo 24 apr. 2019 om 13:20 schreef Sil Boydens notifications@github.com:

screenshot of the older version where it shows a list of recently connected databases [image: image] https://user-images.githubusercontent.com/9578499/56655652-ac647080-6693-11e9-8175-cdf6a625b247.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/patrickTingen/DataDigger/issues/49#issuecomment-486181588, or mute the thread https://github.com/notifications/unsubscribe-auth/ABN3AHMFAEAVF4W2ZTX4AHDPSA667ANCNFSM4HIC3ANA .

SilBoydens commented 5 years ago

For me the menu doesn't show up (that error does show) untill you went I connections and connected to a DB through there. Once you have connected once then it works, even if you disconnect again it still works. Just between starting datadigger and connecting to the first DB it won't work.

I work for a software company so we have hundreds of db's here and datadigger is set to not autoconnect, maybe datadigger autoconnect for you and because of that it doesn't repro the bug

patrickTingen commented 5 years ago

Reproduced it, problem is fixed in next version. If you want to fix it in version 24, open wDataDigger.w, locate procedure "menuDropDataBrowse" and insert as first line (right after the variable declarations):

IF NOT VALID-HANDLE(ghDataBrowse) THEN RETURN.
SilBoydens commented 5 years ago

Thanks, will do

Edit: it works, nice recompiling message