search

patrickTingen / DataDigger

A dynamic dataviewer for your Progress / OpenEdge databases
https://datadigger.wordpress.com/
MIT License
50 stars 24 forks source link

Error when starting datadigger with UTF-8 and windows username with special characters #84

Closed movedoa closed 2 years ago

movedoa commented 2 years ago

Windows User "Kùß Ürè-!"

Starting DataDigger results in the following error:

Invalid character data found in MEMPTR for codepage UTF-8 (12012)

This happens because DataDigger uses the Ansi Version of the API (GetUserNameA) even when the session is started with UTF-8 codepage. (See https://community.progress.com/s/article/How-to-Call-WIN32-API-Function-GetUserName)

When started with UTF-8 DataDigger should use the W versions of all WinApi calls. (GetUserNameA, SendMessageA, SetWindowTextA, SetWindowLongA, ....)

patrickTingen commented 2 years ago

Thanks for reporting, I'll see if I can replace the A-calls with the "W"-version

Op wo 13 apr. 2022 om 12:22 schreef movedoa @.***>:

Windows User "Kùß Ürè-!"

Starting DataDigger results in the following error:

Invalid character data found in MEMPTR for codepage UTF-8 (12012)

This happens because DataDigger uses the Ansi Version of the API (GetUserNameA) even when the session is started with UTF-8 codepage. (See https://community.progress.com/s/article/How-to-Call-WIN32-API-Function-GetUserName )

When started with UTF-8 DataDigger should use the W versions of all WinApi calls. (GetUserNameA, SendMessageA, SetWindowTextA, SetWindowLongA, ....)

— Reply to this email directly, view it on GitHub https://github.com/patrickTingen/DataDigger/issues/84, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABN3AHMOD2KEJKTSDYM6ZVDVE2N75ANCNFSM5TKF2V5A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

patrickTingen commented 2 years ago

I created a local user "Kùß Ürè" on my computer and tested DD in utf-8. It looks good. I also tested a fix for issue #85, please let me know if this works for you

patrickTingen commented 2 years ago

I did a new commit for this, so you might want to download the development branch for this to test.

movedoa commented 2 years ago

Just tried this on my test mashine and boths fixes (#84 and #85) work. Also, this is the first time SokoDigger works with cpinternal UTF-8 :)

Thx for the fix

patrickTingen commented 2 years ago

Glad to hear SokoDigger also works. Admit it; that was your goal! :) (you're not the only one https://is.gd/stats.php?url=EasterEgg that plays it)

Kind regards Patrick Tingen

Op vr 15 apr. 2022 om 11:44 schreef movedoa @.***>:

Just tried this on my test mashine and boths fixes (#84 https://github.com/patrickTingen/DataDigger/issues/84 and #85 https://github.com/patrickTingen/DataDigger/issues/85) work. Also, this is the first time SokoDigger works with cpinternal UTF-8 :)

Thx for the fix

— Reply to this email directly, view it on GitHub https://github.com/patrickTingen/DataDigger/issues/84#issuecomment-1100002428, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABN3AHLJB3AQRNR4Q3COL7LVFE263ANCNFSM5TKF2V5A . You are receiving this because you commented.Message ID: @.***>