search

patrickallaert / php-apm

PHP APM (Alternative PHP Monitor)
http://pecl.php.net/package/APM
Other
310 stars 101 forks source link

add support of mysqlnd driver (alternative to libmysqlclient) #45

Open remicollet opened 8 years ago

remicollet commented 8 years ago

Mostly a proof of concept (tests needed)

patrickallaert commented 7 years ago

By supporting mysqlnd using macros around mysql API, this would dramatically reduce the number of lines of duplicated code.

remicollet commented 7 years ago

I am very much in favor of supporting mysqlnd! I also think it should be the default as of APM 2.2 (new version), what is your opinion on that?

+1 (having dependency on libmysqlclient is not friendly, especially when PHP don't have it anymore)

That way, it also prevents having both drivers at the same time, which is something I would prefer not to support.

This is already not alllowed (if ... elseif ...)

By supporting mysqlnd using macros around mysql API, this would dramatically reduce the number of lines of duplicated code.

This was only a prrof of concept ;) btw this is about lot of conditional vs duplicated code.

I will try to see if a can update this PR (time...)