patrickbr / db-api-to-gtfs

Small hack to convert data from the Deutsche Bahn API into a valid GTFS feed
https://gtfs.de
GNU General Public License v2.0
34 stars 5 forks source link

trip_id is written to trips.txt instead of route_id #4

Closed highsource closed 8 years ago

highsource commented 8 years ago

This:

                trip_writer.writerow({
                    'route_id': tid,
                    'service_id': trip['service_id'],
                    'trip_id': tid,
                    'trip_headsign': trip['headsign']
                })

Should be actually this:

                trip_writer.writerow({
                    'route_id': trip['route_id'],
                    'service_id': trip['service_id'],
                    'trip_id': tid,
                    'trip_headsign': trip['headsign']
                })

I.e. route_id should be trip['route_id'], not tid.

patrickbr commented 8 years ago

Thanks for spotting that typo, you are absolutely right.

highsource commented 8 years ago

Is probably already fixed via merge.

patrickbr commented 8 years ago

Yes, fixed with 58144bae6d02387f9e2b96c3cd5e470586eae28d

highsource commented 8 years ago

Great, thanks. :+1: Nice to work with you.

gerbsen commented 8 years ago

Hey, I just stumbled over this issue, since it is still present in the demo download file available at: http://patrickbrosi.de/de/projects/dbgtfs/. Is there a new file somewhere or should I generate it myself?

highsource commented 8 years ago

@gerbsen I have never told you about https://github.com/fredlockheed/db-fv-gtfs.

gerbsen commented 8 years ago

AWESOME! FYI.. Im currently trying to import this data into our germany endpoint! :) Can't wait to see travel time polygons for ICE's :D

gerbsen commented 8 years ago

Thank you for sharing!

highsource commented 8 years ago

@gerbsen Ah, you're from Route360. :) Great, I'd love to see isochrones for ICEs, too. Please drop me a line when you've got it.

Many thanks to @fredlockheed for the feed.

patrickbr commented 8 years ago

I have updated the feed published on http://patrickbrosi.de/de/projects/dbgtfs/. @fredlockheed's 2016 feed is now also mentioned there!

gerbsen commented 8 years ago

@highsource I've waited years for this: https://apps.route360.net/demo/#/map?areaID=germany&travelTime=120&travelTimeRangeID=2&travelType=transit&colorRangeID=0&sources=51.344741,12.380776&intersection=union&transition=true&mapstyle=mi.0ad4304c

highsource commented 8 years ago

@gerbsen Wow very cool. :)

highsource commented 8 years ago

Many thanks to @patrickbr and @fredlockheed!