search

patrickbussmann / oauth2-apple

Sign in with Apple Provider for the OAuth 2.0 Client
MIT License
96 stars 65 forks source link

Moved fetching Apple JWT keys from token to provider #29

Closed tjveldhuizen closed 3 years ago

tjveldhuizen commented 3 years ago

Since AccessToken is serialized in specific set-ups, existence of the httpClient leads to problems, since closures are not serializable. Also, it's not necessary to keep the httpClient there, since it's only used in the constructor.

Fixes #26, Fixes #28

patrickbussmann commented 3 years ago

Thanks @tjveldhuizen for your pull request. I will check it on the weekend and when everything is fine I'll approve and merge.

tjveldhuizen commented 3 years ago

@patrickbussmann Have you been able to have a look at this?

patrickbussmann commented 3 years ago

Yes sorry. I wanted to improve the test cases and moving to GitHub Actions, too. Now its released + tag + version.

Thanks for your work. 👍