search

patrickbussmann / oauth2-apple

Sign in with Apple Provider for the OAuth 2.0 Client
MIT License
95 stars 64 forks source link

Fix #46 #50

Open SystematicCZ opened 1 year ago

SystematicCZ commented 1 year ago

Fixes #46

Fix Firebase\JWT\JWT::decode(): Argument #3 ($headers) cannot be passed by reference

tjveldhuizen commented 11 months ago

I think this is a pragmatic way to adapt my change in https://github.com/patrickbussmann/oauth2-apple/pull/25 to make this work again. @patrickbussmann do you think this is the right 'solution'? If yes, can you please merge en release this?

kksandr7-deprecated commented 7 months ago

@patrickbussmann Is there any hope that it will be merged?

kksandr7-deprecated commented 7 months ago

These PRs #47, #51 are also trying to solve this problem I believe that they can be closed in favor of this decision.

patrickbussmann commented 7 months ago

@kksandr7 the tests are failing that's why I can't merge it