search

patrickdavey / vimwiki_markdown

A gem to use for converting vimwiki markdown files to html.
MIT License
144 stars 16 forks source link

Update markdown gems #17

Closed patrickdavey closed 5 years ago

patrickdavey commented 5 years ago

This PR updates the underlying gems we depend on (https://github.com/github/markup etc) to be their latest versions. It removes the dependency on rugged, which should fix #14 as well. It removes the dependency on pygments, so, no more dependency on python.

Unfortunately, I wasn't able to nicely keep the tags functionality introduced by @KTSCode . The reason for this is that we're using the github/markup gem, and, at the moment there's no way to pass options through to the commonmark gem. Unfortunately, common mark doesn't like links with spaces. So, while it'll happily change android into a link, it won't do it for [foo bar](foo bar.html). At least, not as far as I can see.

@KTSCode I'm probably going to release this version (0.3.0) with your tags functionality removed. I'm sorry to do that, however, it's about time to bump the dependencies up to modern versions. If the github/markup gem is updated, then I may revisit the tags functionality. If you have time to make another PR with updated code, that would also be great.