search

patrickdavey / vimwiki_markdown

A gem to use for converting vimwiki markdown files to html.
MIT License
144 stars 16 forks source link

Make current directory root_path end with a slash #8

Closed has2k1 closed 7 years ago

has2k1 commented 7 years ago

This makes all values of root_path end with a slash.

This PR results in consistent paths like

./
../
../../
../../../
etc

instead of

.
../
../../
../../../
etc

We do not have to compensate with %root_path%/ which would create double slashes.

patrickdavey commented 7 years ago

This breaks the existing test you wrote for the root_path test, so if you can fix that up it'd be great. Also if you could tweak the version number that'd be great too.

I must work out how to add Travis to this project. Not hard I imagine, and it'll catch these simple kinds of issues.

has2k1 commented 7 years ago

I did not write the test, but I have fixed it.

I have no ruby experience but I have worked with travis a lot. Create an empty .travis.yml file and enable travis for the repo. I can create a PR that fills it in.

has2k1 commented 7 years ago

It turns out that .travis.yml for a ruby project can be very simple.

You can just copy https://github.com/samg/timetrap/blob/master/.travis.yml.

patrickdavey commented 7 years ago

This looks good to me. @okayzed , as you opened up the root_path use in templates with https://github.com/patrickdavey/vimwiki_markdown/pull/3 , I thought I'd just double check if you see any issues with changing the . to a ./ - as far as I can see it'll make things better at minimum :)

okayzed commented 7 years ago

shipit :+1: