search

patrickdemooij9 / SeoToolkit.Umbraco

SeoToolkit is a SEO package for Umbraco 9, 10, 11, 12 & 13. This package features most functionalities needed for your SEO needs like meta fields, sitemap, robots.txt and much more.
MIT License
37 stars 28 forks source link

Using a single quote in meta fields leads to invalid HTML #176

Closed philipdanielhayton closed 1 year ago

philipdanielhayton commented 1 year ago

Hi Patrick,

I've just noticed that the meta tag attributes use single quotes, which leads to invalid markup when the value itself contains a single quote.

For example if the og:title is set to "What's on" then the markup looks like this

<meta property='og:title' content='What's on in' />

I don't think it's a massive issue but it's flagging as an error in https://validator.w3.org.

patrickdemooij9 commented 1 year ago

That will indeed cause some issues. I'll get on it right away!

patrickdemooij9 commented 1 year ago

Fixed by commit https://github.com/patrickdemooij9/SeoToolkit.Umbraco/commit/2e41c7dd83d3f06be8fef4021992c2cd8282f812. Will try to get a new version out tomorrow

philipdanielhayton commented 1 year ago

Legend, thanks for fixing so quickly!

patrickdemooij9 commented 1 year ago

This has been fixed in the latest versions! Thanks again for the report