Open ianleeder opened 1 year ago
Hi @ianleeder, Thank you for the report! I'll take a look at this after my vacation, not quite sure if this is something I would be able to fix or if it should be done in Umbraco itself, but I'll take a look at it!
When editing document types, it seems to trigger two saves:
But when editing content, it only does the SEO save, no content.
@patrickdemooij9 is it possible to actually do the SEO save by hooking into the Content Saved event instead of handling it separately I wonder? There's also an issue here where if you it Save and Publish, it does the two saves but will refresh the content back to the Node you were working on. If I've already moved onto a different node, then there's a race-condition inconsistency with the content and content tree. I'll try to put together a screen recording to show you what I mean.
@robertjf The reason why it is separate now is because it might be confusing to the user if they click "Save and publish" and it also saves the normal content as you are only editing the SEO data. But maybe that idea just lives in my head and combining them would be better, especially if we have race conditions going on. Or do you see the race condition only on the document type save?
If you only make a change on the SEO tab and save the changes, you get the expected green bar:
If you attempt to navigate away from the content node, without having made any changes to the content, you get warned about unsaved changes:
![image](https://github.com/patrickdemooij9/SeoToolkit.Umbraco/assets/8241300/12693c63-4fc9-45fd-acd9-3d82b0c26e27)
Can changes to the SEO tab somehow prevent marking the content node as dirty requiring save?