search

patrickdemooij9 / SeoToolkit.Umbraco

SeoToolkit is a SEO package for Umbraco 9, 10, 11, 12 & 13. This package features most functionalities needed for your SEO needs like meta fields, sitemap, robots.txt and much more.
MIT License
34 stars 28 forks source link

Add tree group to constants #226

Closed erikjanwestendorp closed 11 months ago

erikjanwestendorp commented 12 months ago

@patrickdemooij9 We're considering an addition to one of our projects, specifically the inclusion of a 404 module to extend your package. To achieve this, we've developed a custom tree controller and integrated it into the same TreeGroup (the SeoToolkit TreeGroup). However, our current implementation involves the use of a hardcoded string, which we find somewhat precarious. If you decide to modify the alias of the tree group, our extension would cease to function. Therefore, we'd prefer to use a constant to ensure greater stability and compatibility. If you like the addition I can do this for the section alias as well.

Btw, as far as I know @ambertvu has plans to create a PR to this repo with the 404 extension 😄!

patrickdemooij9 commented 11 months ago

Looking good! Don't see how this could mess anything up. Can't wait to see the 404 extension PR! 🙌