search

patrickdemooij9 / SeoToolkit.Umbraco

SeoToolkit is a SEO package for Umbraco 9, 10, 11, 12 & 13. This package features most functionalities needed for your SEO needs like meta fields, sitemap, robots.txt and much more.
MIT License
34 stars 28 forks source link

Redirect doesn't work if select 'Regex' and 'All Sites' #227

Closed irinamakovetskaya closed 10 months ago

irinamakovetskaya commented 11 months ago

https://github.com/patrickdemooij9/SeoToolkit.Umbraco/blob/414e6c9d94f81cfca9123882d152b13910f84cc3/src/SeoToolkit.Umbraco.Redirects.Core/Services/RedirectsService.cs#L154 if (it.Domain?.Id == 0) return true; // it.Domain is null if you select 'All Sites' and redirect don't used, you need to add check for null too

patrickdemooij9 commented 10 months ago

Fixed by https://github.com/patrickdemooij9/SeoToolkit.Umbraco/pull/242. Thanks for the detailed report! I hope you'll give it a try when the new version comes live