search

patrickdemooij9 / SeoToolkit.Umbraco

SeoToolkit is a SEO package for Umbraco 9, 10, 11, 12 & 13. This package features most functionalities needed for your SEO needs like meta fields, sitemap, robots.txt and much more.
MIT License
38 stars 28 forks source link

Prevent SEO Settings from inheriting from self #293

Open philipdanielhayton opened 3 weeks ago

philipdanielhayton commented 3 weeks ago

Hi Patrick,

This is 100% a user-land issue and nothing at all to do with SeoToolkit, but I've just noticed an issue where if you set the SEO inheritance to the current document type, it will cause 500 server errors on any page of that doc type.

So for example on the HomePage document type, selecting SEO settings to inherit from HomePage.

The fix is simple enough; don't do it! 😅 But maybe there could be some kind of validation to prevent this kind of thing happening. But honestly, it's not at all important and I'm more just leaving this here in case anybody else (or even future me) has a brain fart like this. 😅

patrickdemooij9 commented 3 weeks ago

Hi @philipdanielhayton That indeed sounds like an issue 😅. I'll see if I can make it so that you can't choose the current document type. Thank you for the report!