search

patrickfav / Dali

Dali is an image blur library for Android. It contains several modules for static blurring, live blurring and animations.
https://favr.dev/opensource/dali
Apache License 2.0
1.05k stars 89 forks source link

Update Proguard Rules for Androidx #11

Closed iMJ007 closed 5 years ago

iMJ007 commented 5 years ago

Added Proguard rules required if using Androidx libraires

patrickfav commented 5 years ago

Hi @iMJ007

Thanks for the PR. Here is my feedback:

  1. It is redundant to add the "keep native" methods, as this rule is already present in the default Google Android Proguard rules. See https://android.googlesource.com/platform/sdk/+/master/files/proguard-android.txt
 -keepclasseswithmembernames class * {
    native <methods>;
    }
  1. I think it would be better to add the new rule to the internal library private proguard rule file than just adding this to the readme. See https://github.com/patrickfav/Dali/blob/master/dali/proguard-rules.pro
patrickfav commented 5 years ago

Hey @iMJ007

Just want to check if you are willing to update the PR with my suggestions?

iMJ007 commented 5 years ago

Hey @iMJ007

Just want to check if you are willing to update the PR with my suggestions?

Hello @patrickfav ,

I have updated the Pull Request with suggested changes.

patrickfav commented 5 years ago

LGTM. Thanks for the PR!