search

patrickfav / Dali

Dali is an image blur library for Android. It contains several modules for static blurring, live blurring and animations.
https://favr.dev/opensource/dali
Apache License 2.0
1.05k stars 89 forks source link

Migrate to AndroidX #14

Closed chengmenghuiAndroid closed 4 years ago

patrickfav commented 5 years ago

Hi, could you elaborate what exactly it is you request?

Sh0rxy commented 5 years ago

I assume @chengmenghuiAndroid asks if you might update the libraries you use to match with AndroidX. I came across an error, while I was using the AndroidX library. In API <24 I had all the time SIGSEGV errors. In API >= 24 the error didn't occur. I was also able to reproduce this error in a little test project. Interestingly if I created the same test project and did not use the AndroidX library, but the Android support library, there was no error, even in API's lower than 24.

Most likely it would suffice if you update your project dependency of renderscript from android.support.v8.renderscript.RenderScript to androidx.renderscript.

patrickfav commented 5 years ago

This has maybe something todo with the 64 bit support issue in #16? I will postpne the androidX update because internet dude from stack overflow claims androidX will break the 64 bit support, see: https://stackoverflow.com/a/56477402/774398