search

patrickfav / armadillo

A shared preference implementation for confidential data in Android. Per default uses AES-GCM, BCrypt and HKDF as cryptographic primitives. Uses the concept of device fingerprinting combined with optional user provided passwords and strong password hashes.
https://favr.dev/opensource/armadillo
Apache License 2.0
280 stars 52 forks source link

aar doesnt pull in required dependencies #2

Closed georgepapas closed 6 years ago

georgepapas commented 6 years ago

armadillo depends on bytes and hkdf libraries. It would be nice if there were specified as transitive dependencies in the pom and pulled in automatically.

  implementation "at.favre.lib:bytes:0.4.6"
  implementation "at.favre.lib:hkdf:1.0.0"

Cheers

georgepapas commented 6 years ago

also required

org.mindrot:jbcrypt:0.4

SAGARSURI commented 6 years ago

implementation 'com.jakewharton.timber:timber:4.6.0'

patrickfav commented 6 years ago

This is very strange. I guess the new Gradle syntax "compile" vs "implementation" breaks adding the dependencies to the deployed pom file, I will look into it. This seems to be the same issue as in https://github.com/dcendents/android-maven-gradle-plugin/issues/61

patrickfav commented 6 years ago

I've released v0.4.0, which should include all relevant dependencies. I haven't tryed it yet.

Javinator9889 commented 6 years ago

Continues failing

I have just added the new lib and with both compile and/or implementation, it crashes (seems like the file is not present in the repo). The mentioned URL of the pic: https://jcenter.bintray.com/at/favre/lib/hkdf/1.0.0/hkdf-1.0.0.aar

patrickfav commented 6 years ago

Strange that it gets an .aar, since this is a .jar, will look into it. Looks like the maven plugin messes the dependency types up.

patrickfav commented 6 years ago

So this should finally be resolved with 0.4.1, tested it with a simple app. Closing the ticket, if there are further problems, feel free to reopen or make another report. Cheers.