search

patrickfav / armadillo

A shared preference implementation for confidential data in Android. Per default uses AES-GCM, BCrypt and HKDF as cryptographic primitives. Uses the concept of device fingerprinting combined with optional user provided passwords and strong password hashes.
https://favr.dev/opensource/armadillo
Apache License 2.0
280 stars 52 forks source link

Code review #9

Closed davidmigloz closed 6 years ago

davidmigloz commented 6 years ago

Some improvements and fixes that I've done while reviewing the code.

patrickfav commented 6 years ago

Thanks David, Ill review it in the next couple of days.

davidmigloz commented 6 years ago

Sure, take your time 😄

davidmigloz commented 6 years ago

Btw, I really like the quality of the library. Much much better than other "more popular" libraries that I was reviewing before I found yours. Thank you for your contribution, I really appreciate it 😊

patrickfav commented 6 years ago

Thanks, very honored :) I started to look more into security relevant code in my last project (our code needed to comply with the security guidelines of some major credit card company) and figured that a majority of devs creating security relevant libraries are not really experts in that field (no offense to them of course, everybody starts somewhere), so I created my own.

But anyways, thank you very much for the compliment!

patrickfav commented 6 years ago

Lgtm