patrickfav / bcrypt

A Java standalone implementation of the bcrypt password hash function. Based on the Blowfish cipher it is the default password hash algorithm for OpenBSD and other systems including some Linux distributions. Includes a CLI Tool.
https://favr.dev/opensource/bcrypt
Apache License 2.0
482 stars 49 forks source link

Fix typos and formatting of javadoc an various small issue in code #55

Closed patrickfav closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Base: 88.55% // Head: 88.55% // No change to project coverage :thumbsup:

Coverage data is based on head (51af170) compared to base (8e3de60). Patch coverage: 50.00% of modified lines in pull request are covered.

:exclamation: Current head 51af170 differs from pull request most recent head 9b9a04a. Consider uploading reports for the commit 9b9a04a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #55 +/- ## ========================================= Coverage 88.55% 88.55% Complexity 61 61 ========================================= Files 11 11 Lines 498 498 Branches 92 92 ========================================= Hits 441 441 Misses 21 21 Partials 36 36 ``` | [Impacted Files](https://codecov.io/gh/patrickfav/bcrypt/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle) | Coverage Δ | | |---|---|---| | [...c/main/java/at/favre/lib/crypto/bcrypt/BCrypt.java](https://codecov.io/gh/patrickfav/bcrypt/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle#diff-bW9kdWxlcy9iY3J5cHQvc3JjL21haW4vamF2YS9hdC9mYXZyZS9saWIvY3J5cHRvL2JjcnlwdC9CQ3J5cHQuamF2YQ==) | `85.79% <ø> (ø)` | | | [...va/at/favre/lib/crypto/bcrypt/BCryptFormatter.java](https://codecov.io/gh/patrickfav/bcrypt/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle#diff-bW9kdWxlcy9iY3J5cHQvc3JjL21haW4vamF2YS9hdC9mYXZyZS9saWIvY3J5cHRvL2JjcnlwdC9CQ3J5cHRGb3JtYXR0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | | | [...favre/lib/crypto/bcrypt/BCryptOpenBSDProtocol.java](https://codecov.io/gh/patrickfav/bcrypt/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle#diff-bW9kdWxlcy9iY3J5cHQvc3JjL21haW4vamF2YS9hdC9mYXZyZS9saWIvY3J5cHRvL2JjcnlwdC9CQ3J5cHRPcGVuQlNEUHJvdG9jb2wuamF2YQ==) | `95.12% <ø> (ø)` | | | [.../java/at/favre/lib/crypto/bcrypt/BCryptParser.java](https://codecov.io/gh/patrickfav/bcrypt/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle#diff-bW9kdWxlcy9iY3J5cHQvc3JjL21haW4vamF2YS9hdC9mYXZyZS9saWIvY3J5cHRvL2JjcnlwdC9CQ3J5cHRQYXJzZXIuamF2YQ==) | `94.87% <ø> (ø)` | | | [...avre/lib/crypto/bcrypt/LongPasswordStrategies.java](https://codecov.io/gh/patrickfav/bcrypt/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle#diff-bW9kdWxlcy9iY3J5cHQvc3JjL21haW4vamF2YS9hdC9mYXZyZS9saWIvY3J5cHRvL2JjcnlwdC9Mb25nUGFzc3dvcmRTdHJhdGVnaWVzLmphdmE=) | `100.00% <ø> (ø)` | | | [...ava/at/favre/lib/crypto/bcrypt/Radix64Encoder.java](https://codecov.io/gh/patrickfav/bcrypt/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle#diff-bW9kdWxlcy9iY3J5cHQvc3JjL21haW4vamF2YS9hdC9mYXZyZS9saWIvY3J5cHRvL2JjcnlwdC9SYWRpeDY0RW5jb2Rlci5qYXZh) | `83.92% <ø> (ø)` | | | [...java/at/favre/lib/crypto/bcrypt/cli/CLIParser.java](https://codecov.io/gh/patrickfav/bcrypt/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle#diff-bW9kdWxlcy9iY3J5cHQtY2xpL3NyYy9tYWluL2phdmEvYXQvZmF2cmUvbGliL2NyeXB0by9iY3J5cHQvY2xpL0NMSVBhcnNlci5qYXZh) | `85.00% <50.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Favre-Bulle)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication