Switch Base64 Impl from OpenJDK (GPL2) to Apache - Githubissues

patrickfav / bcrypt

A Java standalone implementation of the bcrypt password hash function. Based on the Blowfish cipher it is the default password hash algorithm for OpenBSD and other systems including some Linux distributions. Includes a CLI Tool.

https://favr.dev/opensource/bcrypt

Apache License 2.0

482 stars 49 forks source link

Switch Base64 Impl from OpenJDK (GPL2) to Apache #8

Closed patrickfav closed 6 years ago

patrickfav commented 6 years ago

So it seems, if I use OpenJDK source, the whole library will be be GPL v2.

It is better to modify the https://commons.apache.org/proper/commons-codec/apidocs/org/apache/commons/codec/binary/Base64.html Apache Commons Codec version.

patrickfav commented 6 years ago

refs #2

patrickfav commented 6 years ago

Here is the discussion about the license: https://opensource.stackexchange.com/questions/7164/i-modified-and-used-gpl2-code-in-my-apache-2-open-source-project-can-my-projec/7165#7165

patrickfav commented 6 years ago

So actually Im not a fan of the Apache Codec Commons implementations seems to focus on code reusability than performance and concisenes. A lot of the lib seems really messy (there is a second Base64 impl e.g. and some exotic codecs and Message Digest impls for any reason)

patrickfav commented 6 years ago

Merged.